Skip to content

Bump firebase dev dependency version number to 8.2.4 #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2021
Merged

Bump firebase dev dependency version number to 8.2.4 #802

merged 1 commit into from
Jan 27, 2021

Conversation

@sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jan 25, 2021

This is a necessary step for b/165671830

@sam-gc sam-gc requested a review from bojeil-google January 25, 2021 23:47
bojeil-google
bojeil-google approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@bojeil-google bojeil-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note our other ongoing FirebaseUI changes may need at least 1 more week (possibly 2). If you want to launch this sooner, I suggest you send a follow up PR (with the emulatorConfig changes copied from third_party/firebaseui).

@sam-gc
Copy link
Contributor Author

sam-gc commented Jan 27, 2021

Okay sounds good. I'll likely end up doing that. Thanks

@sam-gc sam-gc merged commit 9ab63a2 into master Jan 27, 2021
@sam-gc sam-gc deleted the samgho/version-bump branch January 27, 2021 17:35
@sam-gc sam-gc mentioned this pull request Jan 27, 2021
Merged
This was referenced Jun 25, 2021
Open
Open
Open
This was referenced Aug 4, 2021
Open
Open
Open
Open
Open
Open
This was referenced Sep 1, 2021
Open
Open
Open
This was referenced Dec 8, 2021
Open
Open
Open
@mattdanielbrown mattdanielbrown mentioned this pull request May 13, 2022
Open
@mattdanielbrown mattdanielbrown mentioned this pull request Sep 8, 2022
Open
@mattdanielbrown mattdanielbrown mentioned this pull request Oct 25, 2022
Open
@mattdanielbrown mattdanielbrown mentioned this pull request Jun 21, 2023
Open
@mattdanielbrown mattdanielbrown mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bojeil-google bojeil-google bojeil-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bojeil-google bojeil-google

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sam-gc @bojeil-google